fix: resolve failing tests and type errors across api and shared packages#55
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#55stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages - Fix auth middleware HTTP method case-sensitivity (post -> POST) causing 401 on POST /users - Add missing badRequest import in users route - Align shared User type field on 'username' (was 'userName') to match tests - Implement pagination utility in shared package - Configure tsconfig bun-types so process/bun:test resolve without new deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript type errors in the monorepo. Final state: 22 tests pass, 0 fail;
tsc --noEmitclean (exit 0). No test files were modified; no dependencies added.Changes
packages/api/src/middleware/auth.ts) — fixed an HTTP-method case-sensitivity bug: the public-method allow-list contained lowercase"post", so legitimatePOST /usersrequests fell through to auth and returned401. Now"POST".packages/api/src/routes/users.ts) — added the missingbadRequestresponse-helper import that was causing a failure; aligned the create payload on theusernamefield.packages/shared/src/types.ts) — renamed theUserfielduserName→usernameso the type matches what the tests (the source of truth) use. Removed a staleBUG:comment.packages/shared/src/utils/pagination.ts) — implemented the previously-stubbed utility to satisfy its test.bun-typestocompilerOptions.typessoprocessandbun:testresolve at type-check time without adding any dependency.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ no errorsAssumptions
usernamevsuserName), the test was treated as authoritative since test files must not be modified — so the sharedUsertype was changed tousername.bun-typesis already available in the workspace; it was added totsconfigtypesrather than installed as a new dependency.