fix: resolve failing tests and type errors across api and shared packages#56
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#56stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages - Implement paginate() utility with correct edge-case handling - Fix auth middleware case-sensitivity bug (lowercase "post" in public methods allow-list) - Add bun-types to tsconfig compilerOptions so bun:test and process resolve - Fix missing badRequest import and username field-name mismatch in users route - Align User.username field name between packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (now 22 pass / 0 fail) and eliminates all
tsc --noEmittype errors across theapiandsharedpackages. Bugs spanned both packages as expected.Changes
packages/shared/src/utils/pagination.ts— Implemented thepaginate()stub. Handles last partial page, out-of-range pages, empty arrays, and guards against division-by-zero for a zerosize.packages/api/src/middleware/auth.ts— Fixed a case-sensitivity bug: the public-methods allow-list contained lowercase"post", which never matched Hono's uppercasec.req.method, so POST requests wrongly required a token. Changed to"POST".packages/shared/src/types.ts— Renamed theUserfielduserName→usernameto be consistent with the route handlers and tests.packages/api/src/routes/users.ts— Fixed a missingbadRequestimport and theusernamefield reference.tsconfig.json— Added"types": ["bun-types"]tocompilerOptionssobun:testimports andprocessresolve.bun-typeswas already an installed devDependency — no new dependencies added.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ exit 0, zero errorsConstraints honoured
Assumptions
bun-typeswas already present as a devDependency; the type-resolution failures were a tsconfig wiring issue, not a missing package, so the fix was a config directive rather than an install.username(matching the tests and route handlers), so the shared type was aligned to that rather than changing consumers.