fix: make test suite pass and eliminate type errors#59
Open
stooit wants to merge 1 commit into
Open
Conversation
…ing and missing import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (now 22 pass / 0 fail) and eliminates all
tsc --noEmittype errors across theapiandsharedpackages.Changes
packages/shared/src/utils/pagination.ts): implemented thepaginate<T>stub — page slice,total,totalPages,page/pageSize; handles partial last pages, out-of-range pages, and empty arrays.packages/shared/src/types.ts): renamedUserfielduserName→usernameto match every consumer (db, route, tests).packages/api/src/middleware/auth.ts): fixed a case-sensitivity bug — the public-method allow-list checked"post"against Hono's uppercasec.req.method, soPOST /userswas wrongly treated as protected.packages/api/src/routes/users.ts): added the missingbadRequestimport that broke the missing-fields validation path.bun-typestocompilerOptions.typesto resolveprocess/bun:testglobal type errors (no new dependencies).Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ cleanAssumptions / notes
usernamespelling.paginatedoes not guard degenerate inputs (size<=0/page<=0). Not exercised by the suite; adding a throw/clamp would introduce unspecified behaviour, so left out per the mandate. Worth a follow-up if pagination query params get exposed without validation.