fix: resolve all failing tests across utility modules#200
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero - string-utils: implement truncate (word-boundary, ellipsis budget) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy (priority, createdAt) - date-utils: fix formatRelative off-by-one (round instead of floor) - validator: fix isEmail (long TLDs) and isUrl (explicit ports)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across 5 utility modules. The full suite now passes: 60 pass, 0 fail.
Changes
dividenow throws on division by zero instead of returningInfinity.truncate(returns unchanged within limit, respects the ellipsis budget for shortmaxLength, trims to a word boundary) and fixedwordCountto handle consecutive/leading/trailing whitespace.remove,update, andsortBy(priority high→medium→low, andcreatedAtoldest-first) methods.formatRelativeoff-by-one (rounds instead of flooring, so 36 hours reads "1 day ago").isEmail(long TLDs) andisUrl(URLs with explicit ports).BUG:comments that described the now-fixed behaviour.Verification
bun test→ 60 pass, 0 fail, 70 expect() calls.src/implementation changed.Assumptions
truncatecounts the ellipsis towardmaxLengthand prefers a word boundary, per the test cases.