fix: resolve failing tests in TS utility library#206
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: fix wordCount on consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy (priority/createdAt/status) - date-utils: fix off-by-one in formatRelative (round vs floor) - validator: allow long TLDs in isEmail; allow ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library and implements missing functionality. All 60 tests now pass (0 failures); no test files modified and no dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/string-utils.ts—wordCountusestrim().split(/\s+/)so consecutive spaces no longer inflate the count;truncateimplemented (respectsmaxLengthbudget incl. ellipsis, breaks at word boundary, hard-cuts when no space, handlesmaxLengthsmaller than ellipsis).src/task-manager.ts— implementedremove(returnsfalsefor unknown id),update(title/priority, returnsfalsefor unknown id), andsortByforpriority(high>medium>low),createdAt(oldest first), andstatus.src/date-utils.ts— fixed off-by-one informatRelative(Math.roundinstead ofMath.floor; 36h now reads "2 days ago").src/validator.ts—isEmailaccepts long TLDs;isUrlaccepts URLs with a port (e.g.http://localhost:3000).Testing
bun test→ 60 pass, 0 fail.Assumptions
sortBy("status")uses alphabetical order as the tests assert.formatRelativeuses round-to-nearest semantics, matching the test expectations.reviewsubagent: all fixes confirmed as genuine root-cause corrections.🤖 Generated autonomously.