fix: repair failing tests across utility library#207
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: fix wordCount whitespace handling and truncate ellipsis logic - task-manager: complete missing/incomplete TaskManager methods - date-utils: fix formatRelative off-by-one (Math.round instead of floor) - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the TypeScript utility library. All 60 tests now pass; no previously-passing tests were broken. No test files modified, no new dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0, instead of returningInfinity.src/string-utils.ts—wordCountusestrim().split(/\s+/)so consecutive spaces don't yield empty tokens;truncateellipsis accounting corrected.src/task-manager.ts— completed missing/incompleteTaskManagermethods (incl.completeTasksettingcompletedAt).src/date-utils.ts—formatRelativeoff-by-one fixed (Math.roundinstead ofMath.floor), so e.g. 36 hours ago → "2 days ago".src/validator.ts—isEmailnow accepts long TLDs (e.g.user@example.museum);isUrlnow accepts URLs with ports (e.g.http://localhost:3000).Verification
bun test→ 60 pass, 0 fail (70 expect() calls across 5 files).truncatewithmaxLength ≤ 2hard-slices without an ellipsis; not covered by tests and behaviour is unspecified, so left as-is per the "fix only what tests require" constraint.Assumptions
completeTasksetscompletedAtto wall-clocknew Date()rather than an injected timestamp.