fix: resolve all failing tests in utility library#208
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: wordCount handles consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy methods - date-utils: round days in formatRelative to fix off-by-one - validator: accept long TLDs and URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the 5 utility modules. The full suite now passes (60 pass / 0 fail). No test files were modified and no dependencies were added.
Changes
src/calculator.tsdividenow throwsError("Division by zero")instead of returningInfinitysrc/string-utils.tswordCountsplits on/\s+/so consecutive spaces count as one separator;truncateimplemented with word-boundary truncation where the"..."ellipsis counts towardmaxLengthsrc/task-manager.tsremove(returns false for unknown id),update(returns false for unknown id, applies provided fields), andsortBy(priority: high→medium→low; createdAt: oldest first)src/date-utils.tsformatRelativeusesMath.roundfor the days calculation, fixing the off-by-one (36h → "2 days ago")src/validator.tsisEmailaccepts long TLDs ({2,});isUrlaccepts URLs with portsVerification
bun test→ 60 pass, 0 fail, 70 expect() callsAssumptions
formatRelativerounding at the 12–24h boundary;truncatebehaviour whenmaxLength < 3) — left unchanged to avoid altering behaviour the test suite does not exercise.