fix: resolve failing tests across utility library#211
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - string-utils: fix wordCount for consecutive spaces; implement truncate - task-manager: implement remove, update, and sortBy - date-utils: fix off-by-one in formatRelative (round vs floor) - validator: allow long TLDs in isEmail; accept ports in isUrl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across 5 source files. All 60 tests now pass (0 fail), and no previously-passing tests were broken.
Changes
src/calculator.ts—dividenow throws on division by zero (was returningInfinity).src/string-utils.ts—wordCounthandles multiple consecutive spaces;truncateimplemented (word-boundary truncation, ellipsis counts towardmaxLength, handles strings shorter than the ellipsis).src/task-manager.ts— implemented/completedremove,update, andsortBy(priority high→medium→low,createdAtoldest-first).src/date-utils.ts— fixed off-by-one informatRelative(round vs floor; 36h reads as "2 days ago").src/validator.ts—isEmailaccepts long TLDs;isUrlaccepts URLs with a port.Testing
bun test→ 60 pass, 0 fail.Constraints honoured