fix: repair failing tests across utility library#212
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - date-utils: round (not floor) hours-to-days in formatRelative - string-utils: implement truncate, wordCount, slugify - task-manager: implement getByPriority and set completedAt on complete - validator: fix isEmail TLD/subdomain regex and isUrl port handling All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across 5 source files. All 60 tests now pass; no test files were modified and no dependencies were added.
Changes
divide()now throws on division by zero instead of returningInfinity.formatRelative()usesMath.round(notMath.floor) when converting hours to days, fixing the off-by-one (e.g. 36h ago → "2 days ago").truncate,wordCount, andslugify.getByPriority;complete()now setscompletedAtand transitions status correctly.isEmailregex to accept long TLDs/subdomains;isUrlnow uses the URL constructor so ports/paths/queries validate correctly.Verification
bun test→ 60 pass / 0 fail. Independently re-run and confirmed.Review
Reviewed by the review subagent: all fixes are genuine implementations (no hardcoding/overfitting), no regressions, no test files touched.
Assumptions