fix: repair failing utility tests across 5 modules#217
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - date-utils: round (not floor) hours-to-days in formatRelative - validator: accept long TLDs in isEmail and ports in isUrl - string-utils: implement missing utility functions - task-manager: complete missing/incomplete TaskManager methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the TypeScript utility library. The full suite now passes (60 pass / 0 fail).
Changes
calculator.ts—divide()now throwsError("Division by zero")when the divisor is0instead of returningInfinity.date-utils.ts—formatRelative()usesMath.round(notMath.floor) for hours→days, fixing the off-by-one (36h now renders as "2 days ago").validator.ts—isEmail()accepts long TLDs (e.g.user@example.museum);isUrl()accepts URLs with a port (e.g.http://localhost:3000).string-utils.ts— implemented the previously-missing utility functions.task-manager.ts— completed missing/incompleteTaskManagermethods.Verification
bun test→ 60 pass, 0 fail, 70 expect() calls.Constraints honoured