Skip to content

Add first draft of ZXTransformer to contrib.#6647

Closed
dlyongemallo wants to merge 1 commit into
quantumlib:mainfrom
dlyongemallo:zxtransformer
Closed

Add first draft of ZXTransformer to contrib.#6647
dlyongemallo wants to merge 1 commit into
quantumlib:mainfrom
dlyongemallo:zxtransformer

Conversation

@dlyongemallo
Copy link
Copy Markdown
Contributor

This is a custom transformer which uses ZX-calculus through the PyZX library to perform circuit optimisation.

See issue #6585.

@dlyongemallo dlyongemallo requested review from a team, cduck and vtomole as code owners June 13, 2024 18:45
@dlyongemallo dlyongemallo requested a review from dstrain115 June 13, 2024 18:45
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jun 13, 2024
@NoureldinYosri NoureldinYosri self-assigned this Jun 13, 2024
@NoureldinYosri NoureldinYosri self-requested a review June 13, 2024 19:56
Comment thread cirq-core/cirq/contrib/zxtransformer/zxtransformer.py Outdated
Comment thread cirq-core/cirq/contrib/zxtransformer/zxtransformer.py Outdated
Comment thread cirq-core/cirq/contrib/zxtransformer/zxtransformer.py Outdated
Comment thread cirq-core/cirq/contrib/zxtransformer/zxtransformer.py Outdated
@dlyongemallo dlyongemallo marked this pull request as draft July 9, 2024 09:05
@dlyongemallo dlyongemallo force-pushed the zxtransformer branch 3 times, most recently from ef6bcf2 to 443aae0 Compare July 24, 2024 03:23
This is a custom transformer which uses ZX-calculus through the PyZX library to perform circuit optimisation.
@github-actions github-actions Bot added the Stale label Aug 30, 2024
@github-actions github-actions Bot closed this Sep 29, 2024
@mhucka mhucka added the status/stale Closed due to inactivity for an extended period of time label Nov 18, 2024
@mhucka mhucka reopened this Dec 20, 2024
@NoureldinYosri
Copy link
Copy Markdown
Collaborator

@mhucka the contributer has indicated in the issue that they don't have time to work on this #6585 (comment)

@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented Dec 20, 2024

That's correct, but they asked if someone else could take it over; they didn't say to close it. Moreover, the associated issue is still open. Since this PR was auto-closed by bot due to staleness, it seems like the right action is to reopen it and at least have a discussion about whether both the issue and the PR should be closed deliberately.

@github-actions github-actions Bot removed the status/stale Closed due to inactivity for an extended period of time label Dec 21, 2024
@dstrain115
Copy link
Copy Markdown
Collaborator

@naerabati Are you still interested in doing work on the ZX calculus transformer? Want to pick this up?

@naerabati
Copy link
Copy Markdown
Contributor

Sorry I couldn't answer earlier! I don't think right now I will have the time to finish the transformer either

@naerabati
Copy link
Copy Markdown
Contributor

@dstrain115 @dlyongemallo would you be able to tell me what else needs to implemented to complete this PR?

@github-actions
Copy link
Copy Markdown

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com.

@github-actions github-actions Bot added status/stale Closed due to inactivity for an extended period of time and removed status/stale Closed due to inactivity for an extended period of time labels Apr 18, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com.

@github-actions github-actions Bot added the status/stale Closed due to inactivity for an extended period of time label Jul 18, 2025
@github-actions github-actions Bot removed the status/stale Closed due to inactivity for an extended period of time label Jul 19, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com.

@github-actions github-actions Bot added status/stale Closed due to inactivity for an extended period of time and removed status/stale Closed due to inactivity for an extended period of time labels Oct 18, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the status/stale label is not removed by a maintainer within 60 days, this pull request will be closed. If you would like to restore its active status, please leave a comment here; doing so will cause the staleness handler to remove the label.

If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com.

@github-actions github-actions Bot added status/stale Closed due to inactivity for an extended period of time and removed status/stale Closed due to inactivity for an extended period of time labels Jan 18, 2026
@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented Apr 2, 2026

Closing due to inactivity.

@mhucka mhucka closed this Apr 2, 2026
@dlyongemallo
Copy link
Copy Markdown
Contributor Author

I can actually pick this back up. I recently updated the change to use pyzx 0.10.0, which adds support for reset and measurement operations which were previously not available when this PR was first created.

What needs to be done from my end to get this merged?

@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented Apr 9, 2026

@dlyongemallo Thank you for your work. It looks like GitHub will not let me reopen this PR; I get an error message that the branch was "either force-pushed or recreated".

It's possible GitHub will let you reopen it. If the button to reopen the PR is available to you, go ahead and click it.

If it is not available, then the easiest thing to do would be to open a fresh PR. In the PR description, you can write something to the effect of "continuation of PR #6647" or something like that, to help people follow.

@dlyongemallo
Copy link
Copy Markdown
Contributor Author

@mhucka I wasn't able to re-open this. I've opened a fresh PR #8026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants