Skip to content

replace 'homogenous' with 'homogeneous'#8098

Open
caroharris-maker wants to merge 1 commit into
quantumlib:mainfrom
caroharris-maker:patch-1
Open

replace 'homogenous' with 'homogeneous'#8098
caroharris-maker wants to merge 1 commit into
quantumlib:mainfrom
caroharris-maker:patch-1

Conversation

@caroharris-maker
Copy link
Copy Markdown

Change instances of 'homogenous' with 'homogeneous'

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 28, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added the size: S 10< lines changed <50 label May 28, 2026
@pavoljuhas pavoljuhas added the ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. label May 28, 2026

The first pulse, a sqrt(Y) gate, will put the qubit's state on the Bloch
equator. After a delay, successive X gates will refocus dehomogenous
equator. After a delay, successive X gates will refocus dehomogeneous
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native speakers - is dehomogeneous a real word?

Should it be non-homogeneous instead?

Copy link
Copy Markdown
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can someone chime in if we should replace dehomogeneous with non-homogeneous?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (650016f) to head (0c43823).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8098   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files        1114     1114           
  Lines      100849   100849           
=======================================
  Hits       100449   100449           
  Misses        400      400           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka
Copy link
Copy Markdown
Contributor

mhucka commented May 28, 2026

LGTM, but can someone chime in if we should replace dehomogeneous with non-homogeneous?

I'm not a native speaker, but I can say:

  • "dehomogeneous" is a word, but a very specialized technical term used in some areas of math and computer vision, and I don't think its meaning is the sense intended in this PR
  • "nonhomogeneous" is an adjective meaning not uniform throughout, or consisting of parts that are different from each other, but I think that's also not likely to be the sense intended in this PR
  • instead, I believe it should be "inhomogeneous", as in "inhomogeneous phase effects"

Reference: https://pubs.acs.org/doi/10.1021/jp2088109#:~:text=homogeneous%20dephasing%20(decoherence)%20and%20inhomogeneous%20dephasing

@pavoljuhas
Copy link
Copy Markdown
Collaborator

  • instead, I believe it should be "inhomogeneous", as in "inhomogeneous phase effects"

Sounds great, thank you for clearing this up @mhucka!

@caroharris-maker - can you please adjust the PR per Mike's #8098 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants