Skip to content

Hidden chart title#270

Open
vlushaj wants to merge 7 commits into
randym:masterfrom
rubberandglue:master
Open

Hidden chart title#270
vlushaj wants to merge 7 commits into
randym:masterfrom
rubberandglue:master

Conversation

@vlushaj

@vlushaj vlushaj commented Jan 2, 2014

Copy link
Copy Markdown

We have a cool idea to hide chart title.

@bhh

bhh commented Jan 2, 2014

Copy link
Copy Markdown

do we need to specify something specific for rubinius or is the failure just a current travis ci problem?

@jurriaan

jurriaan commented Jan 2, 2014

Copy link
Copy Markdown
Collaborator

It was a travis problem, which is fixed now.

@jurriaan

jurriaan commented Jan 2, 2014

Copy link
Copy Markdown
Collaborator

But, why did you implement it this way? Isn't it simpler to just change Title#to_xml_string so the unless @text.empty? wraps the whole method body?

@bhh

bhh commented Jan 2, 2014

Copy link
Copy Markdown

yep sure i like the empty solution more, i just dont really know if someone uses the possible syntax where a title is shown but blank which leaves a lot of space. its a valid xml version

@jurriaan

jurriaan commented Jan 6, 2014

Copy link
Copy Markdown
Collaborator

On my version of excel it shows 'click here to add title' when using ''. I'm not sure if anybody want's that to appear. Maybe it's better to hide the title when supplying a blank title and have an option to show it anyway?

@vlushaj

vlushaj commented Jan 14, 2014

Copy link
Copy Markdown
Author

we have implemented bar chart 2D (the color of legend is synchronized with color of chart serie).
as you can see, we also have " chart title hidden" new implemented, according to your suggestion.

@randym

randym commented Feb 26, 2014

Copy link
Copy Markdown
Owner

sorry - I am WAY behind the ball of this one. Trying to at least ---reply--- to all the great PR that have come in while I've been snowed under....

How is interoperability with LibreOffice etc, looking on this?
@jurriaan are you happy with this?

@jurriaan

jurriaan commented Mar 3, 2014

Copy link
Copy Markdown
Collaborator

I think it's ok to add this, it should first be rebased on the latest master and if possible, squash some of the commits so it's clearer what happens here.
Also, the indenting should be fix so it matches the indenting used in the rest of axlsx.

@jurriaan

Copy link
Copy Markdown
Collaborator

@valonlushaj any progress? :)

@transparentech

Copy link
Copy Markdown

+1 for 2D charts.

@bhh

bhh commented Jul 4, 2014

Copy link
Copy Markdown

will take care of it soon. probably this month. sorry that i dont have that much time for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants