docs: show the PARSE_DECLTYPES note only on the sqlite tabs#225
Merged
Conversation
The callout sat below the closing tabs shortcode of the Use it section, so every driver selection displayed it. Move it into the aiosqlite and sqlite3 tabs, right under the code samples it refers to.
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the getting-started guide, the callout explaining
detect_types=sqlite3.PARSE_DECLTYPESwas placed after the closing{{< /tabs >}}of the Use it section, so it rendered for every driver selection - including the PostgreSQL drivers it does not apply to.The callout now lives inside the
aiosqliteandsqlite3tabs, directly under the code samples that contain thedetect_typesargument it refers to, and disappears when a PostgreSQL driver tab is selected.Docs-only change, hence the skip-fragment-check label.