Add subtitle field to feed and item fields#299
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
|
@openhand add an inline comment describing your changes |
| ['dc:source', 'source'], | ||
| ['dc:title', 'title'], | ||
| 'title', | ||
| 'subtitle', |
There was a problem hiding this comment.
I'm on it! rbren can track my progress at all-hands.dev
There was a problem hiding this comment.
I've addressed the PR review comment by removing the subtitle field from the fields.item array in lib/fields.js (line 39).
Summary of changes:
- ✅ Removed
'subtitle'fromfields.itemarray as requested by @rbren - ✅ Kept
'subtitle'infields.feedarray (this was not requested to be removed) - ✅ Changes committed and pushed to the
add-subtitle-field-to-parserbranch
Final PR diff (compared to master):
The PR now only adds subtitle to the feed-level fields, not item-level fields:
fields.feed = [
...
'title',
'description',
+ 'subtitle',
'author',
...The changes have been pushed to update PR #299.
Co-authored-by: openhands <openhands@all-hands.dev>
|
🤖 OpenHands is reviewing this PR. Trigger: PR opened at This comment was posted by an AI agent (OpenHands). |
Summary
This PR adds support for parsing the
subtitlefield in RSS feeds.Changes
subtitlefield tofields.feedarray - enables parsing of subtitle elements at the feed levelsubtitlefield tofields.itemarray - enables parsing of subtitle elements at the item levelMotivation
The
subtitlefield is a common RSS element that provides a secondary title or tagline for feeds and items. Previously, this field was only supported for iTunes podcast feeds (viaitunes:subtitle), but the standardsubtitleelement was not being parsed. This change allows the parser to extract subtitle information from standard RSS feeds as well.@rbren can click here to continue refining the PR