Feat/ctx cancelable read#16
Open
J-Zeitler wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rclone serve s3currently does not propagate a cancelled request to the io/file reader level. This PR introduce support for checking contextErr()s on every read.some context/use case: I'm using
rclone serveto expose a zfs dataset stored on mechanical disks. I sometimes accidentally (or just to check if possible/how fast stuff is) issue s3 queries that would scan a lot of this dataset. Realizing such a command will take too much time I'll ctrl+c, but the server will still execute the command to completion. In my case that equates to 99% disk usage for a long time, possibly preventing/stalling actual io ops I want to execute.