Security: Unsafe File Write with User-Controlled Path#1099
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The `outputResult` function writes to a file path specified by the `output` option without any validation. If an attacker can control the `output` parameter (e.g., via CLI `--output` flag), they could write files to arbitrary locations on the filesystem, potentially overwriting critical files or achieving remote code execution by overwriting executable files. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
✅ Deploy Preview for react-docgen canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Unsafe File Write with User-Controlled Path
Problem
Severity:
High| File:packages/react-docgen-cli/src/commands/parse/output/outputResult.ts:L8The
outputResultfunction writes to a file path specified by theoutputoption without any validation. If an attacker can control theoutputparameter (e.g., via CLI--outputflag), they could write files to arbitrary locations on the filesystem, potentially overwriting critical files or achieving remote code execution by overwriting executable files.Solution
Validate and sanitize the
outputpath to ensure it resolves within an expected output directory. Usepath.resolve()and check that the resolved path starts with the allowed base directory. Consider usingfs.realpath()to resolve symlinks before validation.Changes
packages/react-docgen-cli/src/commands/parse/output/outputResult.ts(modified)