feat(push): support generated messages on Windows#16
Merged
Conversation
Resolve the POSIX shell through Git, probe it before pushing, and reuse it across sync push plans. Add Windows-capable unit and integration coverage. # Conflicts: # internal/command/push.go # internal/command/push_message.go # internal/command/push_test.go # internal/command/sync.go
realityforge
force-pushed
the
codex/windows-push-message-shell
branch
from
ac1d304 to
2c2707c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git var GIT_SHELL_PATHWhy
Generated push commit messages were hard-coded to
/bin/shand explicitly rejected Windows, even though Git for Windows exposes the POSIX shell Git itself uses.Validation
bazelisk run @rules_go//go -- fmt ./...bazelisk test //...bazelisk run @rules_go//go -- vet ./...bazelisk run @rules_go//go -- run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.0 runbazelisk test //integration/...