Skip to content

[sets] kick of named args set#8013

Merged
TomasVotruba merged 1 commit into
mainfrom
tv-named-args
May 28, 2026
Merged

[sets] kick of named args set#8013
TomasVotruba merged 1 commit into
mainfrom
tv-named-args

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 28, 2026

Here is kick of from rectorphp/rector#9771

Any rule to add here?
Would it be enough to fix rectorphp/rector#9771?

Comment thread config/set/named-args.php
$rectorConfig->rules([
AddNameToNullArgumentRector::class,
AddNameToBooleanArgumentRector::class,
RemoveNullArgOnNullDefaultParamRector::class,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll split this rules to non-named args and named-args, so it do not interfere with each other.

@TomasVotruba TomasVotruba self-assigned this May 28, 2026
@TomasVotruba TomasVotruba changed the title [sets] kick of named args set [sets] kick of named args set + split of RemoveNullNamedArgOnNullDefaultParamRector to handle named args exlusively May 28, 2026
@TomasVotruba TomasVotruba force-pushed the tv-named-args branch 2 times, most recently from 4280baa to e7a5314 Compare May 28, 2026 10:11
@TomasVotruba TomasVotruba changed the title [sets] kick of named args set + split of RemoveNullNamedArgOnNullDefaultParamRector to handle named args exlusively [sets] kick of named args set May 28, 2026
@TomasVotruba TomasVotruba enabled auto-merge (squash) May 28, 2026 10:12
@TomasVotruba TomasVotruba merged commit cc1d6ee into main May 28, 2026
156 checks passed
@TomasVotruba TomasVotruba deleted the tv-named-args branch May 28, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Apply RemoveNullArgOnNullDefaultParamRector after AddNameToNullArgumentRector has been applied if deadCode: true

1 participant