fix: Forward duration flag to spawned server in blocking runner#140
Open
mcurrier2 wants to merge 1 commit into
Open
fix: Forward duration flag to spawned server in blocking runner#140mcurrier2 wants to merge 1 commit into
mcurrier2 wants to merge 1 commit into
Conversation
The blocking benchmark runner always passed --msg-count (returning 0 in duration mode) to the spawned server process, never forwarding -d. This caused server/client config divergence in duration-based blocking benchmarks — the server would receive --msg-count 0 while the client ran for a specific duration. Now mirrors the async runner's logic: - If config.duration is set, pass -d <seconds> - Otherwise if config.msg_count is set, pass --msg-count <count> - Otherwise pass neither (server uses defaults) Fixes #121 AI-assisted-by: Claude Opus 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📈 Changed lines coverage: 100.00% (4/4)✅ All new and modified lines are covered by tests!📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--msg-countwith conditional duration/msg-count forwardingconfig.durationis set, pass-d <seconds>to the serverconfig.msg_countis set, pass--msg-count <count>Context
The blocking runner always passed
--msg-count 0to the spawned server in duration mode (sinceget_msg_count()returns 0 when duration is set). This caused server/client config divergence — the server would attempt a 0-message run while the client ran for the specified duration. Now mirrors the async runner's logic.Fixes #121
Test plan
Made with Cursor