Fix #125: Implement receive loop in async SHM multi-server handle_connection#144
Open
mcurrier2 wants to merge 1 commit into
Open
Fix #125: Implement receive loop in async SHM multi-server handle_connection#144mcurrier2 wants to merge 1 commit into
mcurrier2 wants to merge 1 commit into
Conversation
…nection The multi-server handle_connection() registered connections in the map but never read messages from them, causing the multi-client SHM path to hang indefinitely with no messages delivered. Additionally, close() did not set the ring buffer shutdown flag, leaving blocked peers spinning until a 5-second timeout. Changes: - Add receive loop in handle_connection() that calls receive_message() and forwards to the message_sender channel - Clone connection before inserting into map (SharedMemoryConnection is Clone) to allow concurrent receive and send operations - Check shutdown flag between receive attempts for clean exit - Remove connection from map on handler exit - Set shutdown flag on all ring buffers in close() before clearing connections (mirrors shared_memory_blocking.rs behavior) - All tests passing, clippy clean AI-assisted-by: Claude Opus 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📈 Changed lines coverage: 0.00% (0/16)🚨 Uncovered lines in this PR
📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_connection()that reads messages viareceive_message()and forwards them to themessage_senderchannelshutdownflag inclose()before clearing connections, so blocked peers wake up cleanly (mirrorsshared_memory_blocking.rs)Test plan
Fixes #125
Made with Cursor