Fix #128: Align transport config defaults between async and blocking runners#147
Open
mcurrier2 wants to merge 1 commit into
Open
Fix #128: Align transport config defaults between async and blocking runners#147mcurrier2 wants to merge 1 commit into
mcurrier2 wants to merge 1 commit into
Conversation
…runners
- Change non-PMQ message_queue_depth from 100 to 10 in blocking runner
to match async runner (non-PMQ transports ignore this field, but
alignment removes confusion when reading configs)
- Change PMQ name format from /ipc_benchmark_{uuid} to
/ipc_benchmark_pmq_{uuid} in blocking runner to match async runner
(both are unique via UUID, this is a cosmetic consistency fix)
- Add documenting comment at max_connections: 1 explaining that
blocking mode is single-threaded by design (vs async concurrency.max(16))
- Add documenting comment at SHM round-trip skip explaining that the
blocking ring buffer is physically unidirectional
- Add documenting comment at PMQ/SHM shutdown messages explaining why
message-oriented transports need explicit shutdown (vs stream-based
EOF detection in async mode)
- No functional behavior changes, no metric impact
- All tests pass, clippy clean, cargo fmt applied
AI-assisted-by: Claude Opus 4 (claude-sonnet-4-20250514)
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution Review failedFailed to post review comments. GitHub was unavailable or timed out while CodeRabbit was posting the review. Please request a new review later if the pull request still needs one. Use ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout. (5)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adjusts blocking-mode transport configuration defaults in src/benchmark_blocking.rs: reducing the adaptive_queue_depth default from 100 to 10, and renaming the PMQ message queue namespace to include a "pmq" segment. It also expands inline documentation explaining blocking-mode behavior for SHM round-trips, single-threaded connections, and PMQ/SHM shutdown handling. ChangesBlocking transport config alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Related issues: Suggested labels: documentation, bug Suggested reviewers: (none identified from provided context) 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📈 Changed lines coverage: 100.00% (2/2)✅ All new and modified lines are covered by tests!📊 Code Coverage Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/benchmark.rs(async) andsrc/benchmark_blocking.rs(blocking) that made the code confusing but did not affect benchmark metricsChanges
message_queue_depth(non-PMQ)100in blocking10(matches async)/ipc_benchmark_{uuid}/ipc_benchmark_pmq_{uuid}(matches async)max_connections: 1Why This Is Safe
message_queue_depthentirelyTest plan
cargo fmt— cleancargo clippy --all-targets -- -D warnings— zero warningscargo test— all 476 tests pass (unit + integration + doc)cargo build --release— clean buildCloses #128
Made with Cursor