Skip to content

augment login telemetry event#6569

Open
masenf wants to merge 3 commits into
mainfrom
masenf/tel-login-event
Open

augment login telemetry event#6569
masenf wants to merge 3 commits into
mainfrom
masenf/tel-login-event

Conversation

@masenf
Copy link
Copy Markdown
Collaborator

@masenf masenf commented May 27, 2026

the uuid already provided this info, but in a less useful way

the uuid already provided this info, but in a less useful way
@masenf masenf requested a review from a team as a code owner May 27, 2026 19:44
@masenf masenf added the skip-changelog For doc/internal changes label May 27, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR enriches the login telemetry event sent to PostHog by adding the authenticated user's email and tier as person properties via PostHog's $set mechanism, and moves user_uuid from a kwarg into the structured properties dict.

  • Email and tier are conditionally included using walrus-operator truthiness checks, so None and empty strings are never forwarded; an empty $set: {} is sent when neither is available, which is a harmless no-op in PostHog.
  • user_uuid is now placed directly inside properties rather than passed as a kwarg; _prepare_event merges it correctly via merged_properties.update(properties), so the event schema is unchanged.

Confidence Score: 5/5

Minimal, well-scoped change to a telemetry call with no effect on app behavior; safe to merge.

The change only touches one telemetry send call: it adds two conditionally-populated person properties and restructures user_uuid from a kwarg to the properties dict. Both paths in _prepare_event correctly handle the new structure, and falsy values are already guarded against before being added to $set.

No files require special attention.

Important Files Changed

Filename Overview
reflex/reflex.py Augments the "login" telemetry event to include email and tier as PostHog person properties via $set, while keeping user_uuid in the event payload; empty/None values are correctly filtered out before inclusion.

Reviews (2): Last reviewed commit: "Merge branch 'main' into masenf/tel-logi..." | Re-trigger Greptile

Comment thread reflex/reflex.py
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 27, 2026

Merging this PR will degrade performance by 4.75%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 23 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
test_get_all_imports[_complicated_page] 2.8 ms 2.9 ms -4.75%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing masenf/tel-login-event (0df1c89) with main (c045e8d)

Open in CodSpeed

@masenf
Copy link
Copy Markdown
Collaborator Author

masenf commented May 28, 2026

@greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant