Skip to content

Track view in viewMap#100

Open
iObject wants to merge 9 commits into
masterfrom
99-optimize-findviewbynodeid-with-an-o1-view-map-m__router_viewmap
Open

Track view in viewMap#100
iObject wants to merge 9 commits into
masterfrom
99-optimize-findviewbynodeid-with-an-o1-view-map-m__router_viewmap

Conversation

@iObject

@iObject iObject commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Base automatically changed from 92-add-popto-support to master April 30, 2026 20:04
@iObject iObject added the create-package create a temporary npm package on every commit label May 1, 2026
@iObject iObject linked an issue May 1, 2026 that may be closed by this pull request
@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on 48d78ab. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260501125643.tgz

iObject added 2 commits May 4, 2026 13:10
_goBack had an inline previousNodeIds scan for keepAlive views whose
id was reassigned on reuse. _popToCheckpoint called findViewByNodeId
with no such fallback, causing it to reject with "view not found"
when the checkpoint target's id had gone stale.

Moved the scan into findViewByNodeId so all callers get the recovery
for free.
…ter_viewmap' of github.com:rokucommunity/sgRouter into 99-optimize-findviewbynodeid-with-an-o1-view-map-m__router_viewmap
@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on fe83de4. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260504161048.tgz

@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on d0177cb. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260505125234.tgz

@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on a0cc6e1. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260505133111.tgz

@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on 7463a0d. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260505134227.tgz

@rokucommunity-bot

Copy link
Copy Markdown
Contributor

Hey there! I just built a new temporary npm package based on 2decc04. You can download it here or install it by running the following command:

npm install https://github.com/rokucommunity/sgRouter/releases/download/v0.0.0-packages/rokucommunity-sgrouter-0.1.2-99-optimize-findviewbynodeid-with-an-o1-view-map-m--router-viewmap.20260525113045.tgz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-package create a temporary npm package on every commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize findViewByNodeId with an O(1) view map (m.__router_viewMap)

2 participants