(Humble) Fix cmake deprecation#420
Conversation
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with a comment.
https://cmake.org/cmake/help/latest/release/3.31.html
for most modern C++ projects, a good starting point is CMake 3.10 or later now.
according to https://github.com/ros-infrastructure/rep/blob/master/rep-2000.rst
- Humble CMake oldest version: 3.14 (Including Tier III)
- Jazzy CMake oldest version: 3.20 (Including Tier III)
i think it is okay to upgrade version 3.20 for rolling and jazzy, 3.14 for humble as base version.
can you also upgrade the CMake version for upstream branches?
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
|
Pulls: #420 |
Description
Cmake version < then 3.10 is deprecated
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information