Skip to content

(Humble) Fix cmake deprecation#420

Open
mosfet80 wants to merge 4 commits into
ros2:humblefrom
mosfet80:patch-1
Open

(Humble) Fix cmake deprecation#420
mosfet80 wants to merge 4 commits into
ros2:humblefrom
mosfet80:patch-1

Conversation

@mosfet80

@mosfet80 mosfet80 commented Jun 5, 2026

Copy link
Copy Markdown

Description

Cmake version < then 3.10 is deprecated

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

mosfet80 added 2 commits June 5, 2026 09:33
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a comment.

https://cmake.org/cmake/help/latest/release/3.31.html

for most modern C++ projects, a good starting point is CMake 3.10 or later now.

according to https://github.com/ros-infrastructure/rep/blob/master/rep-2000.rst

  • Humble CMake oldest version: 3.14 (Including Tier III)
  • Jazzy CMake oldest version: 3.20 (Including Tier III)

i think it is okay to upgrade version 3.20 for rolling and jazzy, 3.14 for humble as base version.

can you also upgrade the CMake version for upstream branches?

@mjcarroll mjcarroll self-assigned this Jun 18, 2026
@mosfet80 mosfet80 changed the title Fix cmake deprecation (Humble) Fix cmake deprecation Jul 5, 2026
@mergify

mergify Bot commented Jul 5, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

mosfet80 added 2 commits July 6, 2026 00:15
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
@ahcorde

ahcorde commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Pulls: #420
Gist: https://gist.githubusercontent.com/ahcorde/05f9c4cb7a549f7c219bb9fbb4a545dd/raw/3e1458c349405f202c61fd18650512d5b3637c1a/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation_cmake
TEST args: --packages-above rmw rmw_implementation_cmake
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19742

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants