Skip to content

Release v5.0.0#2259

Merged
tancnle merged 1 commit into
rouge-ruby:mainfrom
tancnle:release/v5.0.0
May 27, 2026
Merged

Release v5.0.0#2259
tancnle merged 1 commit into
rouge-ruby:mainfrom
tancnle:release/v5.0.0

Conversation

@tancnle

@tancnle tancnle commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@tancnle

tancnle commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator Author

@jneen Since there are a lot of changes since v4.7.1, I am keen to push a new release. Please let me know what you think 🙏🏼.

@tancnle tancnle requested a review from jneen March 24, 2026 03:38
@jneen

jneen commented Mar 24, 2026

Copy link
Copy Markdown
Member

I think there are a couple of things I'd still like to get out before 5.0 if that's alright, but yes I agree in general.

@jneen

jneen commented Mar 24, 2026

Copy link
Copy Markdown
Member

I think I can have everything in by end of this week, worst case early next week. I think we'll be ready to push very soon.

@tancnle

tancnle commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks, @jneen. Let me know once you are ready and I can update this PR.

@tancnle

tancnle commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator Author

@jneen Just checking in to see if we could cut a release sometime this week? 🙏🏼

@jneen

jneen commented Apr 7, 2026

Copy link
Copy Markdown
Member

My inclination is to try and get #2263 in, but that could be 5.1 if need be.

@tancnle

tancnle commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator Author

@jneen, I am keen to exclude #2263 from v5.0.0 to reduce regression risk. We can go for v5.1.0 once #2263 is thoroughly tested.

@jneen

jneen commented Apr 10, 2026

Copy link
Copy Markdown
Member

That sounds fine by me. However, I am finding several recently-introduced bugs as I go through, and am opening separate PRs for those.

@jneen

jneen commented May 20, 2026

Copy link
Copy Markdown
Member

Okay @tancnle I think #2290 is more complicated than I had expected, so I'm going to put off fixing it for now. I think we're ready for 5.0.

@jneen

jneen commented May 20, 2026

Copy link
Copy Markdown
Member

Though that means something like #2264 may drop in a minor release. But that should be 100% backwards compatible on the API layer so I'm not particularly concerned about it.

@tancnle

tancnle commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for confirming @jneen. I will cut a release up to 2a39d31.

@tancnle

tancnle commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@jneen I have updated the MR. Could you have a look and let me know if it looks ok?

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md
**This is a major release** and includes some breaking changes:

- General
- Drop support for EOL Ruby 2.7 ([#2204](https://github.com/rouge-ruby/rouge/pull/2204/) by Nicholas La Roux)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #2286 deserves a mention in the breaking changes section. Essentially, only direct subclasses of Rouge::Formatters::HTML (HTML, HTMLInline, and HTMLDebug) are now allowed when composing HTML formatters, when previously any HTML-like formatter was allowed and would silently do the wrong thing.

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
- Dart Lexer
- Add support for triple-quoted raw strings in Dart lexer ([#2187](https://github.com/rouge-ruby/rouge/pull/2187/) by Modestas Valauskas)
- Dylan Lexer (**NEW**)
- Adds a Dylan lexer ([#2248](https://github.com/rouge-ruby/rouge/pull/2248/) by Jeanine Adkisson)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedro-w should be credited here as well.

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
- update doc links master -> main ([#2229](https://github.com/rouge-ruby/rouge/pull/2229/) by Jeanine Adkisson)
- Fix CI so that it runs on push and PR for main branch ([#2227](https://github.com/rouge-ruby/rouge/pull/2227/) by Nicholas La Roux)
- Add custom RuboCop::Cop::Rouge::NoBuildingAlternationPatternInRegexp cop ([#2224](https://github.com/rouge-ruby/rouge/pull/2224/) by Nicholas La Roux)
- PROPOSAL: add a fallthrough! method for continuing to check later rules ([#2210](https://github.com/rouge-ruby/rouge/pull/2210/) by Jeanine Adkisson)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably remove the PROPOSAL: from the title here.

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md
- Add custom RuboCop::Cop::Rouge::NoBuildingAlternationPatternInRegexp cop ([#2224](https://github.com/rouge-ruby/rouge/pull/2224/) by Nicholas La Roux)
- PROPOSAL: add a fallthrough! method for continuing to check later rules ([#2210](https://github.com/rouge-ruby/rouge/pull/2210/) by Jeanine Adkisson)
- README improvements ([#2219](https://github.com/rouge-ruby/rouge/pull/2219/) by Jeanine Adkisson)
- Safe auto-correct and manually fix RuboCop infractions and regen todo ([#2206](https://github.com/rouge-ruby/rouge/pull/2206/) by Nicholas La Roux)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the Rubocop issues could be grouped somehow?

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
- Update contact email on COC ([#2192](https://github.com/rouge-ruby/rouge/pull/2192/) by Tan Le)
- Bump actions/checkout to v6 ([#2191](https://github.com/rouge-ruby/rouge/pull/2191/) by Tan Le)
- ABAP Lexer
- update ABAP ([#2257](https://github.com/rouge-ruby/rouge/pull/2257/) by Jeanine Adkisson)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co-credit to @mlaggner on this one.

jneen
jneen reviewed May 26, 2026
View reviewed changes
Comment thread CHANGELOG.md Outdated
- fix custom demos ([#2218](https://github.com/rouge-ruby/rouge/pull/2218/) by Jeanine Adkisson)
- various doc fixes ([#2216](https://github.com/rouge-ruby/rouge/pull/2216/) by Jeanine Adkisson)
- Modernize RuboCop usage, add/enable performance, minitest, and rake cops ([#2205](https://github.com/rouge-ruby/rouge/pull/2205/) by Nicholas La Roux)
- Prevent character literals spanning lines ([#2214](https://github.com/rouge-ruby/rouge/pull/2214/) by Tan Le)

@jneen jneen May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could specify this is for Crystal

@jneen

jneen commented May 26, 2026

Copy link
Copy Markdown
Member

Everything else lgtm, thanks for putting this together!

@tancnle

tancnle commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for reviewing @jneen. I have incorporated all your suggestions in 181f5b1 except the Rubocop one. I don't have a good answer for it yet. We might be able to create new subgroups under the General bucket but I feel that can be delayed for future releases.

@jneen

jneen commented May 27, 2026

Copy link
Copy Markdown
Member

I think that's fine, no worries at all.

@tancnle tancnle added this pull request to the merge queue May 27, 2026
Merged via the queue into rouge-ruby:main with commit 96022e4 May 27, 2026
10 checks passed
@tancnle tancnle deleted the release/v5.0.0 branch May 27, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jneen jneen jneen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tancnle @jneen