Fix block comment in Makefile#2305
Merged
Merged
Conversation
7c1a780 to
9530720
Compare
Member
|
Is this supported? idk if i've ever seen it before, usually it's just indented with the block and it's a shell comment. |
Collaborator
Author
|
@jneen It seems supported. Tested with the following $ cat /tmp/Makefile.test
on:
# Start environment
# Start environment (indented)
echo "on"
off:
# Stop environment
# Stop environment (indented)
echo "off"$ make on -f /tmp/Makefile.test
# Start environment (indented)
echo "on"
onIndented comment does not work. It is printed in shell comment in the output |
Member
|
Alright, I think the only other thing is |
9530720 to
b384171
Compare
Collaborator
Author
|
Thanks, @jneen. That sounds good to me 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2301