Fixed illuminator state/control on dual illuminator camera (IL series)#581
Open
Trexano99 wants to merge 1 commit into
Open
Fixed illuminator state/control on dual illuminator camera (IL series)#581Trexano99 wants to merge 1 commit into
Trexano99 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Fix: Dynamic illuminator indexing for Dahua dual smart light cameras (IL Series)
🚨 The Problem
On modern Dahua dual smart light cameras (IL series), the illuminator state and functionality were bugged. Previously, the white light was implicitly assumed to be at
index 0. While this works for single-illuminator cameras, on dual-illuminator models,index 0is assigned to the Infrared (IR) light, which breaks white light controls.🛠️ The Solution
get_illuminator_index: A new function to dynamically identify the correct light index regardless of the camera's hardware layout, cleanly preserving legacy behavior.async_set_lighting_v2: Parameterized the index within the function call, ensuring the dynamically identified light index is resolved before execution.✅ Impact
📝 Documentation & Usage Note
To control the illuminator via the Home Assistant entity, the camera's illuminator mode must be set to
manual.(Tip: Setting the night profile to "manual illuminator" allows for consistent manual control directly from the HA entity).