Refactor gallery search query building#2347
Merged
Merged
Conversation
Build the gallery search WHERE/JOIN clauses with $wpdb->prepare() and $wpdb->esc_like() instead of manual string concatenation, and drop the redundant decode of the already-decoded search parameter. No change to search behavior.
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Refactors gallery search SQL clause construction to reduce manual string concatenation by using $wpdb->prepare() / $wpdb->esc_like(), and removes an unnecessary urldecode() call while aiming to keep search behavior unchanged.
Changes:
- Adds
$wpdb->prepare()and$wpdb->esc_like()for multiple WHERE fragments inrtmedia_search_fillter_where_query(). - Removes
urldecode()from the search parameter sanitation pipeline. - Updates JOIN construction for attribute search to quote the slug via
$wpdb->prepare().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
the-hercules
self-requested a review
July 15, 2026 12:16
the-hercules
previously approved these changes
Jul 15, 2026
the-hercules
previously approved these changes
Jul 15, 2026
krishana7911
left a comment
krishana7911
left a comment
Contributor
There was a problem hiding this comment.
@the-hercules added some comments.
…pes are sanitized
krishana7911
self-requested a review
July 15, 2026 13:47
krishana7911
previously approved these changes
Jul 15, 2026
…ents for trusted identifiers
Contributor
|
Unable to PHPCS or SVG scan one or more files due to error running PHPCS/SVG scanner:
The error may be temporary. If the error persists, please contact a human (commit-ID: b7d7a9f). |
krishana7911
approved these changes
Jul 15, 2026
Comment on lines
+767
to
+768
| $author_id = implode( ',', array_map( 'absint', array_filter( explode( ',', $author_id ) ) ) ); | ||
| $member_type = implode( ',', array_map( 'absint', array_filter( explode( ',', $member_type ) ) ) ); |
Comment on lines
813
to
817
| $where .= " OR $table_name.media_author IN (" . $author_id . ') '; | ||
| } | ||
| if ( ! empty( $member_type ) ) { | ||
| $where .= " OR $table_name.media_author IN (" . $member_type . ') '; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the WHERE/JOIN construction in the gallery search filters (
rtmedia_search_fillter_where_query/rtmedia_search_fillter_join_query) to build clauses with$wpdb->prepare()and$wpdb->esc_like()instead of manual string concatenation, and drops a redundant decode of the already-decoded search parameter. No change to search behavior.