New rake check - compare root url: to filename (without suffix)#1069
Open
jasnow wants to merge 6 commits into
Open
New rake check - compare root url: to filename (without suffix)#1069jasnow wants to merge 6 commits into
jasnow wants to merge 6 commits into
Conversation
Contributor
Author
|
Hint: If you want to see all the failed check, change the start date to 2000 and you will see all of them. |
flavorjones
reviewed
May 27, 2026
Contributor
Author
|
working on failed GHA CI for 2 advisory from yesterday |
Contributor
Author
|
@flavorjones - Now it is ready for re-review. |
flavorjones
reviewed
May 27, 2026
| # Skip advisories older than start_date and old OSVDB advisories. | ||
| if advisory["date"] >= start_date and !filename_root.start_with?("OSVDB") | ||
| expect(url).to include(filename_root), | ||
| "Expected base filename DOES NOT include URL" |
Collaborator
There was a problem hiding this comment.
The "Expected base filename ..." string doesn't do anything here, and should be dropped.
| it "has a filename that matches the root of the url field" do | ||
| url = advisory["url"] | ||
|
|
||
| # Extract filename without extension |
Collaborator
There was a problem hiding this comment.
This comment is probably not necessary, the code is pretty clear.
|
|
||
| # 5/24/2026: May 9, 2026 is earliest start date with no failed checks. | ||
| start_date = Date.new(2026, 5, 9) | ||
| # Skip advisories older than start_date and old OSVDB advisories. |
Collaborator
There was a problem hiding this comment.
This comment is also probably unnecessary, the code reads well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @simi's feedback during the past week or two, I tried to create a new "rake" lint check (rule) for root
url:== basename(filenname).First, since this is a new rule and the large number of failed checks on existing advisories, I decided to pick a start date to start applying it. I found that advisories with
date:> "2026-05-09" all passed. I know this is a compromise but I hope the team agree that the new check is worth the compromise.Second, I skipped the OSVDB advisories because they are very old and that database was removed from the web and internet archive.