fix(examples): repair datacenters SDK drift (US_GA_2 removed from enum)#46
Conversation
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
There was a problem hiding this comment.
Pull request overview
Repairs two Flash examples that broke due to upstream runpod_flash SDK drift and restores missing benchmark example sources so flash dev can discover endpoints again.
Changes:
- Updated datacenter examples to use
DataCenter.US_KS_2(replacing removedUS_GA_2) and aligned the README datacenter table with the SDK enum. - Restored the
07_benchmarking/01_dependency_benchmarkexample (README + two benchmark endpoint files) so endpoints are discoverable again. - Added CPU/system dependency benchmark implementations for numpy and ffmpeg, including version reporting and deterministic output hashing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| 07_benchmarking/01_dependency_benchmark/README.md | Restores documentation for dependency benchmarking and version-comparison workflow. |
| 07_benchmarking/01_dependency_benchmark/numpy_benchmark.py | Restores a numpy benchmarking endpoint with pinned dependency version and result hashing. |
| 07_benchmarking/01_dependency_benchmark/ffmpeg_benchmark.py | Restores an ffmpeg benchmarking endpoint using apt-installed system dependency and timing metrics. |
| 04_scaling_performance/02_datacenters/README.md | Updates datacenter documentation/examples to match current SDK datacenter enum. |
| 04_scaling_performance/02_datacenters/gpu_worker.py | Fixes broken datacenter enum usage by switching to a valid datacenter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DataCenter.US_GA_2 was removed from the runpod_flash DataCenter enum, so 04_scaling_performance/02_datacenters/gpu_worker.py raised AttributeError: US_GA_2 on import and flash dev failed to load it. - Use US_KS_2 for the single-DC and multi-DC examples. - Prune data centers no longer in the enum (US-GA-2, US-MD-1, US-NC-1, EUR-IS-1) from the README table so it matches the SDK.
f0bdb90 to
34f8dea
Compare
|
Resolved the 9 Copilot review threads — all targeted Note: Copilot's benchmark feedback (use |
|
Closing as redundant. The datacenters SDK-drift fix (US_GA_2 -> US_KS_2 in 04_scaling_performance/02_datacenters/gpu_worker.py) already landed on main via a separate commit, so this branch adds nothing: git diff origin/main..origin/fix/example-sdk-drift is empty. Verified 2026-07-06 by running the examples against published runpod-flash 1.18.0. Note the automated review's claim that this PR 'restores missing benchmark example sources' is inaccurate — the only diff was the datacenters file. The benchmark (07) and video_generator (06) sources remain unmerged on their own branches (tmp-07-benchmarking, ae-2222) and are out of scope here. |
|
Correction to my previous comment: this PR is already MERGED (commit ecaf783, 2026-06-29) — that merge is what put US_KS_2 on main. My earlier wording ('landed via a separate commit') was wrong; the fix landed via this PR itself. Nothing to action here. Apologies for the noise. |
Summary
04_scaling_performance/02_datacentersis broken against the currentrunpod_flashSDK:DataCenter.US_GA_2was removed from theDataCenterenum, sogpu_worker.pyraisesAttributeError: US_GA_2on import andflash devfails to load it.Changes
DataCenter.US_KS_2for the single-DC and multi-DC examples ingpu_worker.py.US-GA-2,US-MD-1,US-NC-1,EUR-IS-1) from the README table so it matches the current SDK.Test plan
flash devnow boots the example and discovers endpoints.multi_dc_inferencereturns COMPLETED (US-KS-2 + EU-RO-1); cpu routes OK.ruff format --checkandruff checkpass (pre-commit quality-check green).Note
Scope is datacenters-only. (
07_benchmarking/01_dependency_benchmarkis incomplete onmain— its source lives on the unmergedtmp/07-benchmarkingbranch — so completing it is a separate merge decision, not part of this fix.)