RASR FSA join: add explicit dtypes for cumsum#94
Merged
Conversation
Collaborator
Author
|
I'm not sure why I didn't notice ~2 months ago and now I did. It might have something to do with the somewhat ambiguous default dtype for cumsum:
"Default platform integer" sounds quite ambiguous and prone to issues if one changes the "platform", see e.g. numpy/numpy#9464. Anyway, now that I have the PR ready and a stable commit to pull from, I'll be testing the implementation with my own training. |
hannah220
approved these changes
Mar 30, 2026
michelwi
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use the default dtype, np.cumsum fails when summing here:
This is because the cumsum dtype is actually
np.uint64, and the first common parent ofnp.int32(allows negatives) andnp.uint64(2x more range thannp.int64in the positive side) isnp.float64. Let me provide an example:This PR fixes such an issue with the default cumsum by explicitly setting
np.uint32as default dtype for the cumsum operation.