fix(workbench): drop @sanity/federation from federated-studio#1375
Merged
Conversation
Its only use was unstable_defineApp, which the workbench refactor now re-exports from sanity/cli. Removing it also stops the fixture pinning an older @module-federation/vite transitively.
gu-stav
changed the title
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (8d59d3b) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.16 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 911ms | -1ms, -0.2% |
bin:sanity
| Metric | Value | vs main (8d59d3b) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.06s | -35ms, -1.7% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (8d59d3b3)
| Metric | Value | vs main (8d59d3b) |
|---|---|---|
| Internal (raw) | 106.7 KB | - |
| Internal (gzip) | 26.7 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 808ms | +1ms, +0.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (8d59d3b3)
| Metric | Value | vs main (8d59d3b) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage DeltaNo covered files changed in this PR. Overall Coverage
|
joshuaellis
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
federated-studiofixture pulled in@sanity/federationsolely forunstable_defineApp. After the workbench refactor that helper is re-exported fromsanity/cli(the same import theinitscaffolding now generates), so the fixture can source it from there.Dropping the dep also stops the fixture from pinning an older
@module-federation/vitetransitively — clearing the path for the Renovate bump in #1365 to leave a single resolved version in the lockfile.What to review
fixtures/federated-studio/sanity.cli.tsnow importsunstable_defineAppfromsanity/cli;@sanity/federationis removed from the fixture'spackage.jsonand the lockfile.Testing
Exercised by the existing
build.studiointegration test and thedev.workbenche2e test, both of which run against this fixture. Fixture typechecks clean against the new import.Note
Low Risk
Fixture-only dependency and import path change with no production runtime logic changes.
Overview
The federated-studio fixture no longer depends on
@sanity/federation. It now importsunstable_defineAppalongsidedefineCliConfigfromsanity/cli, matching current init scaffolding after the workbench refactor.Removing the package also drops transitive
@module-federation/viteresolution from this fixture’s lockfile slice, avoiding a duplicate pinned version alongside broader dependency bumps.Reviewed by Cursor Bugbot for commit 4f366db. Bugbot is set up for automated code reviews on this repo. Configure here.