refactor(workbench): drop spec user-story/task refs from comments#1376
Merged
Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (b022ac9) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.16 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 872ms | -3ms, -0.3% |
bin:sanity
| Metric | Value | vs main (b022ac9) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.04s | +33ms, +1.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (b022ac90)
| Metric | Value | vs main (b022ac9) |
|---|---|---|
| Internal (raw) | 106.7 KB | - |
| Internal (gzip) | 26.7 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 773ms | -4ms, -0.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (b022ac90)
| Metric | Value | vs main (b022ac9) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 4 changed files against main @ Overall Coverage
|
The workbench spec (FR-/US- identifiers) lives in a separate repo, so these references carry no meaning here and only add noise to the comments.
5fdc9ca to
638f2c6
Compare
joshuaellis
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The workbench spec (FR-/US- identifiers) lives in a separate repo, so those references carry no meaning in this codebase — this sweeps them out of the comments. Kept as a follow-up on top of the stack so the four reviewed PRs don't need another pass.
What to review
Comment-only changes (plus one cosmetic test title); no behavior change.
Testing
Existing tests unchanged and green.
Note
Low Risk
Documentation and test titles only; no logic, APIs, or runtime paths are modified.
Overview
Strips workbench spec traceability (
FR-024,FR-026,US5, and related doc links) from comments in@sanity/cliand@sanity/workbench-clidev-server code. The explanatory text is kept; only identifiers that point at a spec in another repo are removed.Touches
getDevServerConfig,deriveInterfaces,startDevManifestWatcher,startDevServerRegistration, and matching tests (including renaming one test fromrejects a studio that declares entry (FR-026)to a plain title). A single blank line is added instartDevServerRegistrationbetween fields—formatting only.Reviewed by Cursor Bugbot for commit 638f2c6. Bugbot is set up for automated code reviews on this repo. Configure here.