Skip to content

refactor(workbench): drop spec user-story/task refs from comments#1376

Merged
gu-stav merged 1 commit into
mainfrom
refactor/workbench-drop-spec-refs
Jun 25, 2026
Merged

refactor(workbench): drop spec user-story/task refs from comments#1376
gu-stav merged 1 commit into
mainfrom
refactor/workbench-drop-spec-refs

Conversation

@gu-stav

@gu-stav gu-stav commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

The workbench spec (FR-/US- identifiers) lives in a separate repo, so those references carry no meaning in this codebase — this sweeps them out of the comments. Kept as a follow-up on top of the stack so the four reviewed PRs don't need another pass.

What to review

Comment-only changes (plus one cosmetic test title); no behavior change.

Testing

Existing tests unchanged and green.


Note

Low Risk
Documentation and test titles only; no logic, APIs, or runtime paths are modified.

Overview
Strips workbench spec traceability (FR-024, FR-026, US5, and related doc links) from comments in @sanity/cli and @sanity/workbench-cli dev-server code. The explanatory text is kept; only identifiers that point at a spec in another repo are removed.

Touches getDevServerConfig, deriveInterfaces, startDevManifestWatcher, startDevServerRegistration, and matching tests (including renaming one test from rejects a studio that declares entry (FR-026) to a plain title). A single blank line is added in startDevServerRegistration between fields—formatting only.

Reviewed by Cursor Bugbot for commit 638f2c6. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Stats — @sanity/cli

Compared against main (b022ac90)

@sanity/cli

Metric Value vs main (b022ac9)
Internal (raw) 2.7 KB -
Internal (gzip) 1.0 KB -
Bundled (raw) 11.16 MB -
Bundled (gzip) 2.10 MB -
Import time 872ms -3ms, -0.3%

bin:sanity

Metric Value vs main (b022ac9)
Internal (raw) 782 B -
Internal (gzip) 423 B -
Bundled (raw) 9.87 MB -
Bundled (gzip) 1.78 MB -
Import time 2.04s +33ms, +1.6%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — @sanity/cli-core

Compared against main (b022ac90)

Metric Value vs main (b022ac9)
Internal (raw) 106.7 KB -
Internal (gzip) 26.7 KB -
Bundled (raw) 21.72 MB -
Bundled (gzip) 3.46 MB -
Import time 773ms -4ms, -0.5%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — create-sanity

Compared against main (b022ac90)

Metric Value vs main (b022ac9)
Internal (raw) 908 B -
Internal (gzip) 483 B -
Bundled (raw) 931 B -
Bundled (gzip) 491 B -
Import time ❌ ChildProcess denied: node -
Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

@gu-stav gu-stav marked this pull request as ready for review June 24, 2026 11:20
@gu-stav gu-stav requested a review from a team as a code owner June 24, 2026 11:20
@gu-stav gu-stav requested a review from joshuaellis June 24, 2026 11:20
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Coverage Delta

File Statements
packages/@sanity/cli/src/actions/dev/servers/getDevServerConfig.ts 100.0% (±0%)
packages/@sanity/workbench-cli/src/actions/dev/deriveInterfaces.ts 100.0% (±0%)
packages/@sanity/workbench-cli/src/actions/dev/startDevManifestWatcher.ts 89.4% (±0%)
packages/@sanity/workbench-cli/src/actions/dev/startDevServerRegistration.ts 100.0% (±0%)

Comparing 4 changed files against main @ b022ac90ccee419110485b7b82088bb8d6c99457

Overall Coverage

Metric Coverage
Statements 74.4% (±0%)
Branches 64.3% (±0%)
Functions 69.1% (±0%)
Lines 75.0% (±0%)

@gu-stav gu-stav changed the base branch from refactor/workbench-slim-devaction to main June 24, 2026 11:31
The workbench spec (FR-/US- identifiers) lives in a separate repo, so these
references carry no meaning here and only add noise to the comments.
@gu-stav gu-stav force-pushed the refactor/workbench-drop-spec-refs branch from 5fdc9ca to 638f2c6 Compare June 25, 2026 08:40
@gu-stav gu-stav merged commit 1b7bf66 into main Jun 25, 2026
54 checks passed
@gu-stav gu-stav deleted the refactor/workbench-drop-spec-refs branch June 25, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants