fix(workbench): preview release @module-federation/vite to 1.16.11#1379
Closed
gu-stav wants to merge 1 commit into
Closed
fix(workbench): preview release @module-federation/vite to 1.16.11#1379gu-stav wants to merge 1 commit into
gu-stav wants to merge 1 commit into
Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (adf90ea) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.16 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 875ms | +4ms, +0.5% |
bin:sanity
| Metric | Value | vs main (adf90ea) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.25s | +2ms, +0.1% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (adf90ea6)
| Metric | Value | vs main (adf90ea) |
|---|---|---|
| Internal (raw) | 106.7 KB | - |
| Internal (gzip) | 26.7 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 780ms | +2ms, +0.2% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (adf90ea6)
| Metric | Value | vs main (adf90ea) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Preview this PR with pkg.pr.newRun the Sanity CLInpx https://pkg.pr.new/sanity-io/cli/@sanity/cli@d2119a9 <command>...Or upgrade project dependencies📦
|
Contributor
Coverage DeltaNo covered files changed in this PR. Overall Coverage
|
bcabd66 to
d64b65b
Compare
d64b65b to
70efbab
Compare
gioboa
reviewed
Jun 25, 2026
gioboa
left a comment
There was a problem hiding this comment.
Are those errors related to the new mfe/vite version?
Member
Author
|
@gioboa Thanks for checking in :) They are not related. |
70efbab to
bc2931a
Compare
bc2931a to
cb80a56
Compare
The #RUNTIME-002 fix landed in module-federation/vite#854 (findRemoteEntryFile resolves the manifest's remoteEntry to the container, not a same-named ./App expose). 1.16.11 (#850) didn't carry it, so pin the #854 preview until release.
Member
Author
|
Superseded by #1389, which moves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Note
Makes the upstream fix module-federation/vite#854 available as preview release until 1.16.11 is released.