Skip to content

fix(workbench): preview release @module-federation/vite to 1.16.11#1379

Closed
gu-stav wants to merge 1 commit into
mainfrom
fix/workbench-mf-remoteentry
Closed

fix(workbench): preview release @module-federation/vite to 1.16.11#1379
gu-stav wants to merge 1 commit into
mainfrom
fix/workbench-mf-remoteentry

Conversation

@gu-stav

@gu-stav gu-stav commented Jun 24, 2026

Copy link
Copy Markdown
Member

Description

Note

Makes the upstream fix module-federation/vite#854 available as preview release until 1.16.11 is released.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Stats — @sanity/cli

Compared against main (adf90ea6)

@sanity/cli

Metric Value vs main (adf90ea)
Internal (raw) 2.7 KB -
Internal (gzip) 1.0 KB -
Bundled (raw) 11.16 MB -
Bundled (gzip) 2.10 MB -
Import time 875ms +4ms, +0.5%

bin:sanity

Metric Value vs main (adf90ea)
Internal (raw) 782 B -
Internal (gzip) 423 B -
Bundled (raw) 9.87 MB -
Bundled (gzip) 1.78 MB -
Import time 2.25s +2ms, +0.1%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — @sanity/cli-core

Compared against main (adf90ea6)

Metric Value vs main (adf90ea)
Internal (raw) 106.7 KB -
Internal (gzip) 26.7 KB -
Bundled (raw) 21.72 MB -
Bundled (gzip) 3.46 MB -
Import time 780ms +2ms, +0.2%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — create-sanity

Compared against main (adf90ea6)

Metric Value vs main (adf90ea)
Internal (raw) 908 B -
Internal (gzip) 483 B -
Bundled (raw) 931 B -
Bundled (gzip) 491 B -
Import time ❌ ChildProcess denied: node -
Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Preview this PR with pkg.pr.new

Run the Sanity CLI

npx https://pkg.pr.new/sanity-io/cli/@sanity/cli@d2119a9 <command>

...Or upgrade project dependencies

📦 @sanity/cli
pnpm install https://pkg.pr.new/@sanity/cli@d2119a9
📦 @sanity/cli-build
pnpm install https://pkg.pr.new/@sanity/cli-build@d2119a9
📦 @sanity/cli-core
pnpm install https://pkg.pr.new/@sanity/cli-core@d2119a9
📦 @sanity/cli-test
pnpm install https://pkg.pr.new/@sanity/cli-test@d2119a9
📦 @sanity/eslint-config-cli
pnpm install https://pkg.pr.new/@sanity/eslint-config-cli@d2119a9
📦 @sanity/workbench-cli
pnpm install https://pkg.pr.new/@sanity/workbench-cli@d2119a9

View Commit (d2119a9)

@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Coverage Delta

No covered files changed in this PR.

Overall Coverage

Metric Coverage
Statements 74.4% (±0%)
Branches 64.3% (±0%)
Functions 69.1% (±0%)
Lines 75.0% (±0%)

@gu-stav gu-stav force-pushed the fix/workbench-mf-remoteentry branch 3 times, most recently from bcabd66 to d64b65b Compare June 25, 2026 09:48
@gu-stav gu-stav changed the title fix(workbench): rename generated federation entry to avoid remoteEntry collision fix(workbench): bump @module-federation/vite to 1.16.11 for the remoteEntry fix Jun 25, 2026
@gu-stav gu-stav force-pushed the fix/workbench-mf-remoteentry branch from d64b65b to 70efbab Compare June 25, 2026 10:28

@gioboa gioboa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those errors related to the new mfe/vite version?

@gu-stav

gu-stav commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

@gioboa Thanks for checking in :) They are not related.

@gu-stav gu-stav changed the title fix(workbench): bump @module-federation/vite to 1.16.11 for the remoteEntry fix fix(workbench): preview release @module-federation/vite to 1.16.11 Jun 25, 2026
@gu-stav gu-stav force-pushed the fix/workbench-mf-remoteentry branch from 70efbab to bc2931a Compare June 25, 2026 12:05
@gu-stav gu-stav closed this Jun 25, 2026
@gu-stav gu-stav force-pushed the fix/workbench-mf-remoteentry branch from bc2931a to cb80a56 Compare June 25, 2026 13:23
The #RUNTIME-002 fix landed in module-federation/vite#854 (findRemoteEntryFile
resolves the manifest's remoteEntry to the container, not a same-named ./App
expose). 1.16.11 (#850) didn't carry it, so pin the #854 preview until release.
@gu-stav gu-stav reopened this Jun 25, 2026
@gu-stav

gu-stav commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Superseded by #1389, which moves @module-federation/vite to the released 1.16.11 instead of the pkg.pr.new preview.

@gu-stav gu-stav closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants