Quality: Missing dependency in useEffect cleanup for usb.jsx#665
Open
tomaioo wants to merge 1 commit into
Open
Conversation
The useEffect hook in usb.jsx has a missing dependency: `selectedDeviceId` is used in the cleanup logic (inside the listener) but not included in the dependency array. This can lead to stale closure issues where the cleanup logic references an outdated value of `selectedDeviceId`. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality: Missing dependency in useEffect cleanup for usb.jsx
Problem
Severity:
Medium| File:src/renderer/usb.jsx:L14The useEffect hook in usb.jsx has a missing dependency:
selectedDeviceIdis used in the cleanup logic (inside the listener) but not included in the dependency array. This can lead to stale closure issues where the cleanup logic references an outdated value ofselectedDeviceId.Solution
Add
selectedDeviceIdto the dependency array of the useEffect hook, or use a functional update pattern to avoid the dependency issue.Changes
src/renderer/usb.jsx(modified)