Stabilise reset of fcmpushclient and increase number of retries in gcm_register#34
Closed
WulfgarW wants to merge 2 commits into
Closed
Stabilise reset of fcmpushclient and increase number of retries in gcm_register#34WulfgarW wants to merge 2 commits into
WulfgarW wants to merge 2 commits into
Conversation
…connect_with_retry. The _listen() routine has to take that into account. 2) Sometimes, gcm_register() is not successful with 'retries: int = 4,'. Increased the retries value to 4.
Contributor
Author
|
Okay, adapting fcmpushclient.py and create new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reset of the fcmpushclient sometimes takes several attempts of _connect_with_retry. The _listen() routine has to take that into account.
Sometimes, gcm_register() is not successful with 'retries: int = 4,'. I suggest to increase the retries value to 4.
The suggested code change in this PR was successfully tested by me.