feat: integrate Atlas Cloud provider#1672
Conversation
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const ( | ||
| AIProviderFlagHelp = `AI API provider to generate auto fixes to issues. Valid options are: | ||
| - atlas (Atlas Cloud default), atlas-deepseek-v4-flash, atlas-qwen3-coder-next, atlas-kimi-k2.6, atlas/<model-id>, atlas:<model-id>; |
There was a problem hiding this comment.
Is this a valid syntax to reference the name of any model atlas/<model-id>?
| import "strings" | ||
|
|
||
| const ( | ||
| ModelAtlasDefault = "deepseek-ai/deepseek-v4-flash" |
There was a problem hiding this comment.
Are these consts outside of this package? If not, I would use private names with lower cases.
| // Environment variable for AI API key. | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| aiAPIKeyEnv = "GOSEC_AI_API_KEY" // #nosec G101 | ||
| atlasAPIKeyEnv = "ATLASCLOUD_API_KEY" |
There was a problem hiding this comment.
Why these env variables required? I would just used the generic GOSEC_AI_API_KEY and make introduce something like GOSEC_AI_PROVIDER and you can set it to the specific provider like in this example atlas.
I would like to keep the name of these environment variables generic. Thanks
| @@ -0,0 +1,5 @@ | |||
| GOSEC_AI_API_KEY=your_atlas_cloud_api_key | |||
| ATLASCLOUD_API_KEY=your_atlas_cloud_api_key | |||
There was a problem hiding this comment.
I would remove this env variable. It seems duplicate to me. They need to be generic and provider agnostic.
| @@ -0,0 +1,42 @@ | |||
| # Atlas Cloud Provider Review | |||
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
lucaszhu-hue
temporarily deployed
to
security-review
GitHub Actions
Inactive
|
@lucaszhu-hue please fix the lint issues from https://github.com/securego/gosec/actions/runs/26225722816/job/77174959167?pr=1672 |
ravisastryk
left a comment
ravisastryk
left a comment
There was a problem hiding this comment.
Good to see additional cloud providers getting added. lgtm
4 participants
Added Atlas Cloud provider and docs.