feat(proof): feat(proof): support single-threaded proof generation#1090
Open
pengqima wants to merge 1 commit into
Open
feat(proof): feat(proof): support single-threaded proof generation#1090pengqima wants to merge 1 commit into
pengqima wants to merge 1 commit into
Conversation
## Description BREAKING CHANGE: n re semaphore-protocol#1072
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: n
re #1072
Description
This PR adds an optional
GenerateProofOptionsargument togenerateProofand forwards itssingleThreadflag to thesnarkjsGroth16 prover.In runtimes where worker threads are unavailable, such as Bun v1.3.2, proof generation currently fails before a proof can be produced. Consumers can now opt into single-threaded proof generation:
The existing multithreaded behavior remains the default, so this change is backward-compatible.
This PR also:
validates the singleThread option at runtime
exports the new GenerateProofOptions type
documents the new option in the proof package README
adds a regression test that generates a valid proof in single-threaded mode
updates @types/snarkjs to a version that includes the prover options supported by the installed snarkjs runtime
Related Issue(s)
Closes #1072
Other information
Checklist
yarn formatandyarn lintwithout getting any errorsImportant
We do not accept pull requests for minor grammatical fixes (e.g., correcting typos, rewording sentences) or for fixing broken links, unless they significantly improve clarity or functionality. These contributions, while appreciated, are not a priority for merging. If you notice any of these issues, please create a GitHub Issue to report them so they can be properly tracked and addressed.