CPLAT-10878: esc exits conversation view to session list when preview closed#69
Merged
Merged
Conversation
In a plain conversation view (no task/agent/cron drilldown, preview already closed), esc was a no-op — only left exited to the session list. Make esc behave like left in that state so it returns to the session list. Earlier esc presses still pop a drilldown or close the preview first, unchanged. CPLAT-10878
Kairo-Kim
approved these changes
Jul 15, 2026
Kairo-Kim
added
the
auto-review/approved
mitrilmad
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://sendbird.atlassian.net/browse/CPLAT-10878
What
In the ccx TUI conversation view,
escnow exits back to the session list when there is no drilldown and the preview pane is already closed.Why
Previously, in a plain conversation view (no task/agent/cron drilldown, preview closed),
escwas a no-op — onlyleft(←/h) exited to the session list, which was unintuitive. Nowescbehaves likeleftin that state.Earlier
escpresses are unchanged: they still pop a drilldown back into the parent conversation (re-opening its preview) or close the preview pane first, before this final exit step.Implementation
internal/tui/conversation.go: in the!sp.Showplain-conv branch of the esc handler, seta.state = viewSessionsinstead of returning a no-op.TestEscFromTaskDrilldownReturnsToParentConv(third esc now exits), renamedTestEscFromPlainConvStaysInConvList→TestEscFromPlainConvExitsToConvList.Test
go build ./...,go test ./internal/tui/ -run TestEscpass.