fix: route all URL opens through configured opener#72
Merged
Conversation
The References preview and URL action menu open URLs via App.openInBrowser,
which hardcoded exec.Command("open", url) and ignored open.command_template.
So a configured opener (e.g. "tmux-chrome open {{url}}") never applied to the
most common open paths — only the conversation artifact page browser used it.
- openInBrowser now falls through to opener.Open(a.config.Open, url) (still
overridable via a.openURL for tests).
- conversation.go / urls.go route through openInBrowser instead of calling
opener.Open directly, so the test hook + config handling live in one place.
Regression test: TestOpenInBrowserUsesConfiguredOpener.
Kairo-Kim
approved these changes
Jul 16, 2026
jinsekim
added
the
auto-review/approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
open.command_template(예:tmux-chrome open {{url}}) 설정이 References preview·URL 액션 메뉴에서 안 먹던 문제.PR #70에서 URL opener를 추가했지만
conversation.go/urls.go만opener.Open으로 바꿨고, 가장 흔한 open 경로인App.openInBrowser(refs preview에서 PR 여는 경로)는 하드코딩된exec.Command("open", url)그대로였다. 그래서 config가 conversation artifact page browser 외에는 적용되지 않았다.Fix
openInBrowser가opener.Open(a.config.Open, url)로 폴백 (테스트용a.openURLoverride는 유지).conversation.go/urls.go도opener.Open직접 호출 대신openInBrowser를 거치게 통일 → 테스트 hook + config 처리가 한 곳에 모임.Test
TestOpenInBrowserUsesConfiguredOpenergo build ./...,go vet ./...,go test ./...전부 통과Note
이 수정 후
make install로 새 바이너리를 설치하고 ccx를 재시작해야 적용됨. (실행 중인 옛 바이너리는open:섹션 자체를 모름)