Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions tests/system/tests/test_groupadd.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,84 @@ def test_groupadd__u_option_empty_string_clears_members(shadow: Shadow):
assert gshadow_entry is not None, "Group should be found"
assert gshadow_entry.name == "tgroup", "Incorrect groupname"
assert not gshadow_entry.members, "Group should have no members"


@pytest.mark.topology(KnownTopology.Shadow)
def test_groupadd__set_gid(shadow: Shadow):
"""
:title: Create group with specific GID using -g flag
:setup:
1. Create group with specific GID
:steps:
1. Check group entry
:expectedresults:
1. Group entry is created with the specified GID
:customerscenario: False
"""
shadow.groupadd("-g 1500 tgroup")

group_entry = shadow.tools.getent.group("tgroup")
assert group_entry is not None, "Group should be found"
assert group_entry.name == "tgroup", "Incorrect groupname"
assert group_entry.gid == 1500, "Incorrect GID"


@pytest.mark.topology(KnownTopology.Shadow)
def test_groupadd__set_password(shadow: Shadow):
"""
:title: Add group with password using -p flag
:setup:
1. Create group with password
:steps:
1. Check group entry
2. Check gshadow entry
:expectedresults:
1. Group entry is created
2. Group's password is correctly set
:customerscenario: False
"""
shadow.groupadd("-p Secret123 tgroup")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the group entry check:

group_entry = shadow.tools.getent.group("tgroup")
assert group_entry is not None, "Group tgroup should be found"
...

group_entry = shadow.tools.getent.group("tgroup")
assert group_entry is not None, "Group should be found"

gshadow_entry = shadow.tools.getent.gshadow("tgroup")
assert gshadow_entry is not None, "Group should be found"
assert gshadow_entry.name == "tgroup", "Incorrect groupname"
assert gshadow_entry.password is not None, "Password should not be None"
assert re.match(shadow_password_pattern(), gshadow_entry.password), "Incorrect password"


@pytest.mark.topology(KnownTopology.Shadow)
def test_groupadd__force_group_creation(shadow: Shadow):
"""
:title: Forced creation of existing group exits successfully
:setup:
1. Create group entry
:steps:
1. Check existing group entry
2. Force create exiting group entry
3. Check group entry
4. Check gshadow entry
:expectedresults:
1. Group entry is created
2. Command groupadd -f tgroup exits successfully without error
3. Group entry in group file is unchanged with the original name
4. Group entry in gshadow file is unchanged with the original name
:customerscenario: False
"""
shadow.groupadd("tgroup")

existing_group_entry = shadow.tools.getent.group("tgroup")
assert existing_group_entry is not None, "Group should be found"
Comment on lines +137 to +138

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing in the steps


shadow.groupadd("-f tgroup")

group_entry = shadow.tools.getent.group("tgroup")
assert group_entry is not None, "Group should be found"
assert group_entry.name == "tgroup", "Incorrect groupname"

if shadow.host.features["gshadow"]:
gshadow_entry = shadow.tools.getent.gshadow("tgroup")
assert gshadow_entry is not None, "Group should be found"
assert gshadow_entry.name == "tgroup", "Incorrect groupname"