-
Notifications
You must be signed in to change notification settings - Fork 275
Tests: Add system tests for groupadd in test_groupadd.py #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asakure
wants to merge
3
commits into
shadow-maint:master
Choose a base branch
from
asakure:system_tests_groupadd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,3 +66,84 @@ def test_groupadd__u_option_empty_string_clears_members(shadow: Shadow): | |
| assert gshadow_entry is not None, "Group should be found" | ||
| assert gshadow_entry.name == "tgroup", "Incorrect groupname" | ||
| assert not gshadow_entry.members, "Group should have no members" | ||
|
|
||
|
|
||
| @pytest.mark.topology(KnownTopology.Shadow) | ||
| def test_groupadd__set_gid(shadow: Shadow): | ||
| """ | ||
| :title: Create group with specific GID using -g flag | ||
| :setup: | ||
| 1. Create group with specific GID | ||
| :steps: | ||
| 1. Check group entry | ||
| :expectedresults: | ||
| 1. Group entry is created with the specified GID | ||
| :customerscenario: False | ||
| """ | ||
| shadow.groupadd("-g 1500 tgroup") | ||
|
|
||
| group_entry = shadow.tools.getent.group("tgroup") | ||
| assert group_entry is not None, "Group should be found" | ||
| assert group_entry.name == "tgroup", "Incorrect groupname" | ||
| assert group_entry.gid == 1500, "Incorrect GID" | ||
|
|
||
|
|
||
| @pytest.mark.topology(KnownTopology.Shadow) | ||
| def test_groupadd__set_password(shadow: Shadow): | ||
| """ | ||
| :title: Add group with password using -p flag | ||
| :setup: | ||
| 1. Create group with password | ||
| :steps: | ||
| 1. Check group entry | ||
| 2. Check gshadow entry | ||
| :expectedresults: | ||
| 1. Group entry is created | ||
| 2. Group's password is correctly set | ||
| :customerscenario: False | ||
| """ | ||
| shadow.groupadd("-p Secret123 tgroup") | ||
|
|
||
| group_entry = shadow.tools.getent.group("tgroup") | ||
| assert group_entry is not None, "Group should be found" | ||
|
|
||
| gshadow_entry = shadow.tools.getent.gshadow("tgroup") | ||
| assert gshadow_entry is not None, "Group should be found" | ||
| assert gshadow_entry.name == "tgroup", "Incorrect groupname" | ||
| assert gshadow_entry.password is not None, "Password should not be None" | ||
| assert re.match(shadow_password_pattern(), gshadow_entry.password), "Incorrect password" | ||
|
|
||
|
|
||
| @pytest.mark.topology(KnownTopology.Shadow) | ||
| def test_groupadd__force_group_creation(shadow: Shadow): | ||
| """ | ||
| :title: Forced creation of existing group exits successfully | ||
| :setup: | ||
| 1. Create group entry | ||
| :steps: | ||
| 1. Check existing group entry | ||
| 2. Force create exiting group entry | ||
| 3. Check group entry | ||
| 4. Check gshadow entry | ||
| :expectedresults: | ||
| 1. Group entry is created | ||
| 2. Command groupadd -f tgroup exits successfully without error | ||
| 3. Group entry in group file is unchanged with the original name | ||
| 4. Group entry in gshadow file is unchanged with the original name | ||
| :customerscenario: False | ||
| """ | ||
| shadow.groupadd("tgroup") | ||
|
|
||
| existing_group_entry = shadow.tools.getent.group("tgroup") | ||
| assert existing_group_entry is not None, "Group should be found" | ||
|
Comment on lines
+137
to
+138
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is missing in the steps |
||
|
|
||
| shadow.groupadd("-f tgroup") | ||
|
|
||
| group_entry = shadow.tools.getent.group("tgroup") | ||
| assert group_entry is not None, "Group should be found" | ||
| assert group_entry.name == "tgroup", "Incorrect groupname" | ||
|
|
||
| if shadow.host.features["gshadow"]: | ||
| gshadow_entry = shadow.tools.getent.gshadow("tgroup") | ||
| assert gshadow_entry is not None, "Group should be found" | ||
| assert gshadow_entry.name == "tgroup", "Incorrect groupname" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the group entry check: