Skip to content

fix: handle todo_write string inputs#342

Open
Bill-Billion wants to merge 1 commit into
shareAI-lab:mainfrom
Bill-Billion:codex/fix-todo-write-string-input
Open

fix: handle todo_write string inputs#342
Bill-Billion wants to merge 1 commit into
shareAI-lab:mainfrom
Bill-Billion:codex/fix-todo-write-string-input

Conversation

@Bill-Billion
Copy link
Copy Markdown
Collaborator

@Bill-Billion Bill-Billion commented Jun 2, 2026

Fixes #340. Thanks @ThreeLeaves66 for reporting that todo_write can receive todos as a list-like string and then fail validation with todos[0] missing content or status.

Changes

  • Normalize todo_write inputs in s05, s07, s08, and s20.
  • Parse JSON array strings first, then safely fall back to ast.literal_eval for Python list repr strings.
  • Keep strict validation for list/object shape and todo status values.
  • Add regression coverage for issue S05_todo_write工具调用的时候有入参问题 #340, including a guard that string inputs are not evaluated with unsafe eval.
  • Run all Python tests in CI so the new regression test is covered.

Verification

  • /tmp/lcc-py312-venv/bin/python -m pytest tests -q -> 18 passed, 12 subtests passed
  • PATH=/tmp/lcc-py312-venv/bin:$PATH bash "${CLAUDE_SKILL_DIR:-$HOME/.agents/skills/check}/scripts/run-tests.sh" -> 18 passed
  • npm run build in web -> passed

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

@Bill-Billion is attempting to deploy a commit to the crazyboym's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S05_todo_write工具调用的时候有入参问题

1 participant