PyQt5 to PyQt6#23
Merged
Merged
Conversation
PyQt6 needs Python >= 3.9, and macos-11 is retired. Reduce the build test to building only; release packaging stays in release.yml. - macos-11 -> macos-15, ubuntu-22.04 -> ubuntu-latest - python 3.8 -> 3.12 - libfuse2 -> libfuse2t64 for noble; checkout@v4, setup-python@v5 - use "python -m pip" so pip self-upgrade works on Windows - drop deploy step that broke on PR refs (github.ref_name slash) Signed-off-by: Huang Rui <vowstar@gmail.com>
Bytecode encryption was removed in PyInstaller 6.0, so --key aborts the Windows build. Signed-off-by: Huang Rui <vowstar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the GUI from PyQt5 to PyQt6.
Supersedes #21. The PyQt5 to PyQt6 commits are the original work of
@jiapei100 (Pei Jia), cherry-picked here with authorship preserved;
all credit for the migration goes to him.
#21 could not go green because its CI matrix pinned Python 3.8 while
PyQt6 >= 6.8 requires Python >= 3.9, and the macos-11 runner is
retired. This PR adds one commit on top to fix the build-test matrix:
Verified locally: deps install and MainWindow constructs under PyQt6
(QIcon.Mode/State, QApplication.primaryScreen, app.exec()).
Closes #21.