fix(fe): course/admin/[courseId] Tab central arrangement problem#3650
fix(fe): course/admin/[courseId] Tab central arrangement problem#3650HajunPark-skku wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prevents the default event behavior on the admin data table's delete button click and adjusts the layout alignment of the course detail navigation tabs. The reviewer recommended using justify-center instead of justify-between for the navigation tabs to maintain proper visual grouping on larger screens.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <div className="mx-auto my-10 w-full"> | ||
| <div className="w-full"> | ||
| <nav className="flex w-full justify-start border-b border-gray-200"> | ||
| <nav className="flex w-full justify-between border-b border-gray-200"> |
There was a problem hiding this comment.
Using justify-between on a full-width container (w-full) where the child tabs have a fixed width (w-[285.5px]) will cause the tabs to spread far apart on large screens, leaving large empty gaps between them. This breaks the visual grouping of the navigation bar. Since the PR title indicates a 'central arrangement' issue, using justify-center is a much better approach to keep the tabs grouped together in the center of the screen on all resolutions.
| <nav className="flex w-full justify-between border-b border-gray-200"> | |
| <nav className="flex w-full justify-center border-b border-gray-200"> |
egg-zz
added
preview
|
apps/frontend/app/admin/course/[courseId]/layout.tsx에서 충돌났다는데 확인 한 번 해주세요~ |
|
❗ Syncing Preview App Failed Application: |
…rse-courseidtab-center
|
✅ Syncing Preview App Succeeded Application: |
충돌원인: main의 2701d66 커밋이 [courseId]/layout.tsx를 (overview)/layout.tsx로 이동시키면서 옛 경로 파일을 삭제 → 우리 브랜치는 옛 경로를 수정한 상태라 modify/delete 충돌 발생한것으로 보입니다! 해결: git merge origin/main 실행 → git이 rename을 자동 인식해서 충돌 없이 최근 수정사항(flex-1, justify-between 제거)을 새 경로 (overview)/layout.tsx에 그대로 이식할 수 있도록 조치했습니다 확인 부탁드립니다~ |
egg-zz
added
preview
|
✅ Syncing Preview App Succeeded Application: |
3 participants
Description
프로필을 누르고 강의에 들어가면 관리 → 강좌 →홈 / 멤버 / 과제 ... 등등. 탭 형식으로 되어 있다.화면을 크게 늘리면 탭이 중앙이 아닌 왼쪽으로 정렬되는데, 이를 양쪽으로 고르게 퍼지도록 수정하였다.
Additional context
Before submitting the PR, please make sure you do the following
fixes #123).Closes TAS-2786