Skip to content

fix: surface initial fields in lists.items.create method arguments #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zimeg wants to merge 7 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix: surface initial fields in lists.items.create method arguments #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
885a6b2
fix: correct typo in lists.items.create parameter name
zimeg Jun 10, 2026
264d976
test: add assertion verifying initial_fields are applied on item create
zimeg Jun 10, 2026
49b2484
test: strengthen initial_fields assertions in remote test
zimeg Jun 10, 2026
573f145
test: assert exact text value of initial_fields in created item
zimeg Jun 10, 2026
b1a05fe
Merge branch 'main' into fix/lists-items-create-initial-fields-typo
zimeg Jun 10, 2026
70cc842
Merge branch 'main' into fix/lists-items-create-initial-fields-typo
zimeg Jun 10, 2026
2da94f7
Merge branch 'main' into fix/lists-items-create-initial-fields-typo
mwbrooks Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slack-api-client/src/main/java/com/slack/api/methods/RequestFormBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2880,7 +2880,7 @@ public static FormBody.Builder toForm(SlackListsItemsCreateRequest req) {
setIfNotNull("parent_item_id", req.getParentItemId(), form);
if (req.getInitialFields() != null) {
String json = getJsonWithGsonAnonymInnerClassHandling(req.getInitialFields());
form.add("intial_fields", json);
form.add("initial_fields", json);

@mwbrooks mwbrooks Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice catch 🎉 Silent param-drops are the worst flavour of bug because nothing 4xxs and the request just succeeds with the field missing.

}
return form;
}
Expand Down
4 changes: 4 additions & 0 deletions slack-api-client/src/test/java/test_with_remote_apis/methods/slacklists_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ public void fullSlackListsWorkflow() throws IOException, SlackApiException {
assertThat(createItemResponse.getError(), is(nullValue()));
assertThat(createItemResponse.isOk(), is(true));
assertThat(createItemResponse.getItem(), is(notNullValue()));
assertThat(createItemResponse.getItem().getFields(), is(notNullValue()));
assertThat(createItemResponse.getItem().getFields().size(), is(1));
assertThat(createItemResponse.getItem().getFields().get(0).getColumnId(), is(taskNameColId));
assertThat(createItemResponse.getItem().getFields().get(0).getText(), is("Test task item"));
Comment on lines +164 to +167

@zimeg zimeg Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪬 note: We now confirm the fields used above:

[DEBUG] createItemResponse item=ListRecord(id=Rec0B9VCSAABE, listId=F0B9KD6NECB, fields=[ListRecord.Field(key=task_name, columnId=Col0B9TKAUTND, value=[{"type":"rich_text","block_id":"h2z2t","elements":[{"type":"rich_text_section","elements":[{"type":"text","text":"Test task item"}]}]}], text=Test task item, richText=[RichTextBlock(type=rich_text, elements=[RichTextSectionElement(type=rich_text_section, elements=[RichTextSectionElement.Text(type=text, text=Test task item, style=null)])], blockId=h2z2t)], messages=null, message=null, number=null, select=null, date=null, user=null, attachment=null, checkbox=null, email=null, phone=null, channel=null, rating=null, timestamp=null, link=null, reference=null)], dateCreated=1781134963, createdBy=U09KU686163, threadTs=null, position=null, updatedTimestamp=1781134963, updatedBy=U09KU686163, viewPositions=null, platformRefs=null, isSubscribed=null, saved=null, savedFields=null)


String itemId = createItemResponse.getItem().getId();
assertThat(itemId, is(notNullValue()));
Expand Down