Skip to content

chore: open changeset release pull requests as draft#2629

Merged
zimeg merged 1 commit into
mainfrom
chore/draft-release-prs
Jun 19, 2026
Merged

chore: open changeset release pull requests as draft#2629
zimeg merged 1 commit into
mainfrom
chore/draft-release-prs

Conversation

@zimeg

@zimeg zimeg commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Open changeset release PRs as drafts using the prDraft: create option from changesets/action. This prevents version PRs from being accidentally merged before they're reviewed.

Reference: https://github.com/changesets/action/blob/main/CHANGELOG.md#180

Requirements

@zimeg zimeg requested a review from a team as a code owner June 17, 2026 17:56
@changeset-bot

changeset-bot Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: def067d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mwbrooks
mwbrooks requested changes Jun 17, 2026
View reviewed changes
Comment thread packages/cli-test/src/cli/cli-process.test.ts
@zimeg
chore: open changeset release PRs as draft
def067d 
Use the `prDraft: create` option from changesets/action to open version
PRs in draft mode, requiring explicit approval before merging.

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg zimeg force-pushed the chore/draft-release-prs branch from 475e42e to def067d Compare June 17, 2026 22:21
@codecov

codecov Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (59124ef) to head (def067d).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2629   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          63       63           
  Lines       10256    10256           
  Branches      452      452           
=======================================
  Hits         9118     9118           
  Misses       1117     1117           
  Partials       21       21
Flag Coverage Δ
cli-hooks 88.90% <ø> (ø)
cli-test 88.90% <ø> (ø)
logger 88.90% <ø> (ø)
oauth 88.90% <ø> (ø)
socket-mode 88.90% <ø> (ø)
web-api 88.90% <ø> (ø)
webhook 88.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimeg

zimeg commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

📣 For #2628!

@zimeg zimeg self-assigned this Jun 17, 2026
@zimeg zimeg added area:performance issues where performance is a meaningful concern release labels Jun 17, 2026
@zimeg zimeg requested a review from mwbrooks June 17, 2026 22:26
@zimeg zimeg changed the title chore: open changeset release PRs as draft chore: open changeset release pull requests as draft Jun 17, 2026
WilliamBergamin
WilliamBergamin approved these changes Jun 19, 2026
View reviewed changes

@WilliamBergamin WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please please please please

@zimeg

zimeg commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

@WilliamBergamin Consider it done! Thanks for the review! And thanks @mwbrooks too 🐢 ✨

@zimeg zimeg merged commit 6945147 into main Jun 19, 2026
12 checks passed
@zimeg zimeg deleted the chore/draft-release-prs branch June 19, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamBergamin WilliamBergamin WilliamBergamin approved these changes

@mwbrooks mwbrooks Awaiting requested review from mwbrooks

Assignees

@zimeg zimeg

Labels

area:performance issues where performance is a meaningful concern release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg @mwbrooks @WilliamBergamin