refactor: move internal manifest package to internal/manifest#590
Open
mwbrooks wants to merge 1 commit into
Open
refactor: move internal manifest package to internal/manifest#590mwbrooks wants to merge 1 commit into
mwbrooks wants to merge 1 commit into
Conversation
The internal/pkg/ directory is a generic catch-all that the codebase is moving away from; new packages live directly under internal/. This change relocates the manifest package to internal/manifest/ with no behavioral change. Extracted from #543 to keep that PR's diff focused on the two-way manifest sync feature.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 71.66% 71.66% -0.01%
==========================================
Files 226 226
Lines 19176 19176
==========================================
- Hits 13743 13742 -1
- Misses 4222 4223 +1
Partials 1211 1211 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mwbrooks
added
code health
mwbrooks
changed the title
zimeg
approved these changes
Jun 12, 2026
| "github.com/slackapi/slack-cli/internal/app" | ||
| "github.com/slackapi/slack-cli/internal/cmdutil" | ||
| "github.com/slackapi/slack-cli/internal/iostreams" | ||
| "github.com/slackapi/slack-cli/internal/pkg/manifest" |
Member
There was a problem hiding this comment.
🪓 praise: This diff is beautiful to call out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request moves the
manifestpackage frominternal/pkg/manifest/tointernal/manifest/with no behavioral changes.internal/pkg/directory is a generic catch-all the codebase is moving away from using.internal/manifestlive directly underinternal/.Preview
N/A — internal package relocation, no surface change.
Testing
make test- run by the CI/CDRequirements