feat: opt-in deletion protection for cluster control plane log group#53
Open
sm-utkarsh wants to merge 1 commit into
Open
feat: opt-in deletion protection for cluster control plane log group#53sm-utkarsh wants to merge 1 commit into
sm-utkarsh wants to merge 1 commit into
Conversation
Exposes clusterConfig.logGroupDeletionProtection and logGroupRetentionDays so consumers can protect /aws/eks/<clusterName>/cluster from accidental deletion. Defaults to off/infinite retention to preserve existing behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clusterConfig.logGroupDeletionProtectionandclusterConfig.logGroupRetentionDaystoClusterConfig.logGroupDeletionProtectionistrue,EKSClusternow creates/manages the control plane log group (/aws/eks/<clusterName>/cluster) withDeletionProtectionset, guarding it against accidental deletion (e.g. via console oraws logs delete-log-group).logGroupRetentionDaysis set. Passinglogs.RetentionDays.INFINITEexplicitly is handled correctly (that enum sentinel isn't a valid literal for CloudFormation, so it's translated to "omit the property").Motivated by a security finding on
sib-infra-cdk-prod-eks: EKS cluster logs were forwarded to CloudWatch but the log group had no deletion protection, risking loss of audit/monitoring data.Test plan
tsc --noEmitpasses cleanlysib-infra-cdk-prod-eks,cdk synth, confirm theAWS::Logs::LogGroupresource hasDeletionProtection: trueand correctLogGroupNamecdk diff/deployagainst SIB-PROD to confirm no disruption to existing control plane logging