feat: inject canonical DON ID into capability configuration#22635
Draft
tarcisiozf wants to merge 4 commits into
Draft
feat: inject canonical DON ID into capability configuration#22635tarcisiozf wants to merge 4 commits into
tarcisiozf wants to merge 4 commits into
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
tarcisiozf
force-pushed
the
CRE-4409-capability-don-id
branch
from
277a60d to
429e88e
Compare
|
|
| } | ||
| // Host-injected: overwrite anything TOML or on-chain SpecConfig may have set. | ||
| // See CapabilityDonIDConfigKey doc. | ||
| merged[CapabilityDonIDConfigKey] = info.donID |
Contributor
There was a problem hiding this comment.
Suggested change
| merged[CapabilityDonIDConfigKey] = info.donID | |
| if info.donID > 0 { | |
| merged[CapabilityDonIDConfigKey] = info.donID | |
| } |
we want to make sure we're not inheriting 0 values if its not set.
Contributor
There was a problem hiding this comment.
for capabilities/triggers that are instantiated via job spec, this path will not be triggered, so I believe it's not complete. Lets discuss offline
tarcisiozf
force-pushed
the
CRE-4409-capability-don-id
branch
from
0f4bd72 to
0de458e
Compare
tarcisiozf
force-pushed
the
CRE-4409-capability-don-id
branch
from
0de458e to
fe20419
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports